From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: netlink: Subscribe nft monitor and nft monitor trace to respective groups.
Date: Tue, 25 Jul 2017 18:06:42 +0200 [thread overview]
Message-ID: <20170725160642.GA3466@salvia> (raw)
In-Reply-To: <5976d630.c553650a.2e876.31e8@mx.google.com>
Hi Varsha,
On Tue, Jul 25, 2017 at 10:55:00AM +0530, Varsha Rao wrote:
> Subscribe nft monitor only to NFNLGRP_NFTABLES and nft monitor trace
> only to NFNLGRP_NFTRACE. In netlink_monitor() depending on the command
> call setsockopt() once.
Could you enhance this patch in a way that things work like the
following:
#1 nft monitor
This prints all events, both nftrace and nftables.
#2 nft monitor trace
This prints only trace events.
#3 nft monitor ruleset
This prints only ruleset events.
for #3, you have to extend the bison parser I think, it should be not
too complicated.
>+ if (monhandler->monitor_flags == (unsigned int)-1)
I think there must be a way to make this more readable, as well as
make it work in the way I propose above.
Thanks!
prev parent reply other threads:[~2017-07-25 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 5:25 [PATCH nft] src: netlink: Subscribe nft monitor and nft monitor trace to respective groups Varsha Rao
2017-07-25 16:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725160642.GA3466@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).