From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH v2 0/3] monitor: Some fixes and improvements
Date: Tue, 25 Jul 2017 20:39:41 +0200 [thread overview]
Message-ID: <20170725183944.9377-1-phil@nwl.cc> (raw)
This is v2 containing the patches not applied from v1. Apart from
rebasing upon current upstream master, I folded patch 4 into patch 1
since they really belong together: The code changes to make 'nft
monitor' print correct syntax (by including the mandatory semicolons)
harmed readability since it dropped whitespace from the output. Former
patch 4 resolved this, not only for the cases patch 1 broke, but also at
another spot (i.e. between 'type' attribute and the following ones).
Patch 2 of this series depends on patch 1 since the simplification
requires that 'nft monitor' output matches given input (apart from
whitespace change) which wasn't the case before patch 1.
Finally, patch 3 (along with patch 2) remains unchanged.
Phil Sutter (3):
monitor: Fix printing of set declarations
tests/monitor: Simplify testcases
tests/monitor: Clear ruleset after testing
src/rule.c | 8 ++++----
tests/monitor/run-tests.sh | 15 ++++++++++-----
tests/monitor/testcases/set-maps.t | 7 +++----
tests/monitor/testcases/set-mixed.t | 10 +++-------
tests/monitor/testcases/set-multiple.t | 7 ++-----
tests/monitor/testcases/set-simple.t | 21 ++++++++-------------
6 files changed, 30 insertions(+), 38 deletions(-)
--
2.13.1
next reply other threads:[~2017-07-25 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 18:39 Phil Sutter [this message]
2017-07-25 18:39 ` [nft PATCH v2 1/3] monitor: Fix printing of set declarations Phil Sutter
2017-07-25 18:39 ` [nft PATCH v2 2/3] tests/monitor: Simplify testcases Phil Sutter
2017-07-25 18:39 ` [nft PATCH v2 3/3] tests/monitor: Clear ruleset after testing Phil Sutter
2017-07-27 8:50 ` [nft PATCH v2 0/3] monitor: Some fixes and improvements Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725183944.9377-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).