From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] mnl: Remove dead code
Date: Thu, 27 Jul 2017 10:46:46 +0200 [thread overview]
Message-ID: <20170727084646.GB5576@salvia> (raw)
In-Reply-To: <20170726161630.12919-1-phil@nwl.cc>
Cc'ing Pablo Bermudo.
On Wed, Jul 26, 2017 at 06:16:30PM +0200, Phil Sutter wrote:
> Remove the functions mnl_nft_rule_add() and *_delete() since they are
> not used throughout the code. Commit a72315d2bad47 ("src: add rule
> batching support") changed their only caller to use the batch variant
> introduced at the same time.
I think there are more useless functions. Pablo Bermudo mentioned this
to me a while ago. At least I remember some of them in netlink.c?
If not much asking, it would be good if we can kill them all in one go.
next prev parent reply other threads:[~2017-07-27 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 16:16 [nft PATCH] mnl: Remove dead code Phil Sutter
2017-07-27 8:46 ` Pablo Neira Ayuso [this message]
2017-08-07 16:54 ` Pablo M. Bermudo Garay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727084646.GB5576@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).