From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2 0/3] monitor: Some fixes and improvements
Date: Thu, 27 Jul 2017 10:50:56 +0200 [thread overview]
Message-ID: <20170727085056.GA5843@salvia> (raw)
In-Reply-To: <20170725183944.9377-1-phil@nwl.cc>
On Tue, Jul 25, 2017 at 08:39:41PM +0200, Phil Sutter wrote:
> This is v2 containing the patches not applied from v1. Apart from
> rebasing upon current upstream master, I folded patch 4 into patch 1
> since they really belong together: The code changes to make 'nft
> monitor' print correct syntax (by including the mandatory semicolons)
> harmed readability since it dropped whitespace from the output. Former
> patch 4 resolved this, not only for the cases patch 1 broke, but also at
> another spot (i.e. between 'type' attribute and the following ones).
>
> Patch 2 of this series depends on patch 1 since the simplification
> requires that 'nft monitor' output matches given input (apart from
> whitespace change) which wasn't the case before patch 1.
>
> Finally, patch 3 (along with patch 2) remains unchanged.
Series applied, thanks a lot for addressing all my feedback!
prev parent reply other threads:[~2017-07-27 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 18:39 [nft PATCH v2 0/3] monitor: Some fixes and improvements Phil Sutter
2017-07-25 18:39 ` [nft PATCH v2 1/3] monitor: Fix printing of set declarations Phil Sutter
2017-07-25 18:39 ` [nft PATCH v2 2/3] tests/monitor: Simplify testcases Phil Sutter
2017-07-25 18:39 ` [nft PATCH v2 3/3] tests/monitor: Clear ruleset after testing Phil Sutter
2017-07-27 8:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727085056.GA5843@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).