From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH RFC v2 3/4] Implement --echo option
Date: Thu, 27 Jul 2017 18:54:35 +0200 [thread overview]
Message-ID: <20170727165435.GS2235@orbyte.nwl.cc> (raw)
In-Reply-To: <20170727164300.GA10637@salvia>
On Thu, Jul 27, 2017 at 06:43:00PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Jul 27, 2017 at 06:21:43PM +0200, Phil Sutter wrote:
> > diff --git a/include/linux/netfilter/nf_tables.h b/include/linux/netfilter/nf_tables.h
> > index 40096de04e963..70404f724808a 100644
> > --- a/include/linux/netfilter/nf_tables.h
> > +++ b/include/linux/netfilter/nf_tables.h
> > @@ -114,6 +114,7 @@ enum nf_tables_msg_types {
> > NFT_MSG_GETOBJ,
> > NFT_MSG_DELOBJ,
> > NFT_MSG_GETOBJ_RESET,
> > + NFT_MSG_META_ECHO,
>
> Why this?
See netlink_echo_callback(): I want to reuse monitor code as much as
possible, and therefore introduced that function as common callback
dispatching to monitor callbacks. In order to make them print data like
I want them to, I need to have an indicator. The simplest way was to
introduce this fake type which in callbacks acts as third option to
NFT_MSG_NEW* or NFT_MSG_DEL*.
Cheers, Phil
next prev parent reply other threads:[~2017-07-27 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:21 [nft PATCH RFC v2 0/4] Implement --echo option Phil Sutter
2017-07-27 16:21 ` [nft PATCH RFC v2 1/4] mnl: Consolidate mnl_batch_talk() parameters Phil Sutter
2017-07-27 16:21 ` [nft PATCH RFC v2 2/4] netlink: Pass nlmsg flags from rule.c Phil Sutter
2017-07-27 16:21 ` [nft PATCH RFC v2 3/4] Implement --echo option Phil Sutter
2017-07-27 16:43 ` Pablo Neira Ayuso
2017-07-27 16:54 ` Phil Sutter [this message]
2017-07-27 16:56 ` Pablo Neira Ayuso
2017-07-27 17:00 ` Phil Sutter
2017-07-27 16:21 ` [nft PATCH RFC v2 4/4] tests: Add a simple test suite for " Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727165435.GS2235@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).