netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH v3 0/4] Implement --echo option
Date: Fri, 28 Jul 2017 13:55:44 +0200	[thread overview]
Message-ID: <20170728115548.5171-1-phil@nwl.cc> (raw)

Long description of what it is and how it works in patch 3. Patches 1
and 2 are dependencies to patch 3.

I noticed that netlink_events_*_cb() functions accept 'type' parameter
as signed integer, which allows to pass a negative value to enable echo
printing mode without the risk of colliding with one of
nf_tables_msg_types values.

Another change since v2 is a minor fix of the added documentation in
nft.xml - I used <cmd> tag which is not known.

Phil Sutter (4):
  mnl: Consolidate mnl_batch_talk() parameters
  netlink: Pass nlmsg flags from rule.c
  Implement --echo option
  tests: Add a simple test suite for --echo option

 doc/nft.xml                   |  52 +++++++++++++++++
 include/mnl.h                 |   4 +-
 include/netlink.h             |  12 ++--
 include/nftables.h            |   1 +
 src/main.c                    |  11 +++-
 src/mnl.c                     |  31 ++++++++--
 src/netlink.c                 | 133 +++++++++++++++++++++++++++++-------------
 src/rule.c                    |  33 ++++++-----
 tests/echo/run-tests.sh       |  53 +++++++++++++++++
 tests/echo/testcases/simple.t |   8 +++
 10 files changed, 272 insertions(+), 66 deletions(-)
 create mode 100755 tests/echo/run-tests.sh
 create mode 100644 tests/echo/testcases/simple.t

-- 
2.13.1


             reply	other threads:[~2017-07-28 11:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 11:55 Phil Sutter [this message]
2017-07-28 11:55 ` [nft PATCH v3 1/4] mnl: Consolidate mnl_batch_talk() parameters Phil Sutter
2017-08-02 12:36   ` Pablo Neira Ayuso
2017-07-28 11:55 ` [nft PATCH v3 2/4] netlink: Pass nlmsg flags from rule.c Phil Sutter
2017-08-02 12:36   ` Pablo Neira Ayuso
2017-08-02 12:58     ` Pablo Neira Ayuso
2017-08-02 13:38       ` Phil Sutter
2017-07-28 11:55 ` [nft PATCH v3 3/4] Implement --echo option Phil Sutter
2017-08-02 12:37   ` Pablo Neira Ayuso
2017-08-02 13:18     ` Pablo Neira Ayuso
2017-08-02 13:45       ` Phil Sutter
2017-07-28 11:55 ` [nft PATCH v3 4/4] tests: Add a simple test suite for " Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170728115548.5171-1-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).