From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [nft PATCH v3 2/4] netlink: Pass nlmsg flags from rule.c Date: Wed, 2 Aug 2017 14:58:57 +0200 Message-ID: <20170802125857.GA8908@salvia> References: <20170728115548.5171-1-phil@nwl.cc> <20170728115548.5171-3-phil@nwl.cc> <20170802123640.GB16003@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Phil Sutter Return-path: Received: from ganesha.gnumonks.org ([213.95.27.120]:51763 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdHBM7V (ORCPT ); Wed, 2 Aug 2017 08:59:21 -0400 Content-Disposition: inline In-Reply-To: <20170802123640.GB16003@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Aug 02, 2017 at 02:36:40PM +0200, Pablo Neira Ayuso wrote: > On Fri, Jul 28, 2017 at 01:55:46PM +0200, Phil Sutter wrote: > > There is no point in checking value of excl in each called function. > > Just do it in a single spot and pass resulting flags. > > Also applied, thanks. Oops. I have to keep this back, sorry. It breaks testcases/rule_management/0003insert_0. Please run tests before submitting, thanks!