From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v3 2/4] netlink: Pass nlmsg flags from rule.c
Date: Wed, 2 Aug 2017 15:38:41 +0200 [thread overview]
Message-ID: <20170802133841.GG16375@orbyte.nwl.cc> (raw)
In-Reply-To: <20170802125857.GA8908@salvia>
On Wed, Aug 02, 2017 at 02:58:57PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 02, 2017 at 02:36:40PM +0200, Pablo Neira Ayuso wrote:
> > On Fri, Jul 28, 2017 at 01:55:46PM +0200, Phil Sutter wrote:
> > > There is no point in checking value of excl in each called function.
> > > Just do it in a single spot and pass resulting flags.
> >
> > Also applied, thanks.
>
> Oops. I have to keep this back, sorry.
>
> It breaks testcases/rule_management/0003insert_0.
Oh, it breaks insert command for rules.
> Please run tests before submitting, thanks!
Will do, sorry!
Thanks, Phil
next prev parent reply other threads:[~2017-08-02 13:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 11:55 [nft PATCH v3 0/4] Implement --echo option Phil Sutter
2017-07-28 11:55 ` [nft PATCH v3 1/4] mnl: Consolidate mnl_batch_talk() parameters Phil Sutter
2017-08-02 12:36 ` Pablo Neira Ayuso
2017-07-28 11:55 ` [nft PATCH v3 2/4] netlink: Pass nlmsg flags from rule.c Phil Sutter
2017-08-02 12:36 ` Pablo Neira Ayuso
2017-08-02 12:58 ` Pablo Neira Ayuso
2017-08-02 13:38 ` Phil Sutter [this message]
2017-07-28 11:55 ` [nft PATCH v3 3/4] Implement --echo option Phil Sutter
2017-08-02 12:37 ` Pablo Neira Ayuso
2017-08-02 13:18 ` Pablo Neira Ayuso
2017-08-02 13:45 ` Phil Sutter
2017-07-28 11:55 ` [nft PATCH v3 4/4] tests: Add a simple test suite for " Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802133841.GG16375@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).