From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 4/4] netfilter: rt: add support to fetch path mss
Date: Tue, 8 Aug 2017 15:47:39 +0200 [thread overview]
Message-ID: <20170808134739.GB5151@breakpoint.cc> (raw)
In-Reply-To: <1502199450.4487.15.camel@edumazet-glaptop3.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Tue, 2017-08-08 at 15:15 +0200, Florian Westphal wrote:
> > + struct dst_entry *dst;
> > + struct flowi fl;
[..]
> > + ai = nf_get_afinfo(nft_pf(pkt));
> > + if (ai)
> > + ai->route(nft_net(pkt), &dst, &fl, false);
> > +
>
> if ai is NULL,
>
> dst is not initialized and might contain garbage.
Right, thanks for pointing this out, I sent a v2.
next prev parent reply other threads:[~2017-08-08 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 13:15 [PATCH nf-next 0/4] netfilter: nftables: tcp mss mangling support Florian Westphal
2017-08-08 13:15 ` [PATCH nf-next 1/4] netfilter: exthdr: factor out tcp option access Florian Westphal
2017-08-08 13:15 ` [PATCH nf-next 2/4] netfilter: exthdr: split netlink dump function Florian Westphal
2017-08-08 13:15 ` [PATCH nf-next 3/4] netfilter: exthdr: tcp option set support Florian Westphal
2017-08-08 13:15 ` [PATCH nf-next 4/4] netfilter: rt: add support to fetch path mss Florian Westphal
2017-08-08 13:37 ` Eric Dumazet
2017-08-08 13:47 ` Florian Westphal [this message]
2017-08-08 13:48 ` [PATCH v2 " Florian Westphal
2017-08-19 12:05 ` [PATCH nf-next 0/4] netfilter: nftables: tcp mss mangling support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808134739.GB5151@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).