From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls
Date: Tue, 15 Aug 2017 12:25:00 +0200 [thread overview]
Message-ID: <20170815102500.GA3928@salvia> (raw)
In-Reply-To: <20170814234305.2829-2-phil@nwl.cc>
On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote:
> Echo support in nft_mnl_talk() was broken: nft_mnl_talk_cb() passed
> cbdata->data as second parameter to netlink_echo_callback() which
> expected it to be of type struct netlink_ctx while in fact it was
> whatever callers of nft_mnl_talk() passed as callback data (in most
> cases a NULL pointer).
Applied, thanks.
> I didn't notice this because I didn't test for kernels without support
> for transactions. This has been added to nftables in kernel version 3.16
> back in 2014. Since then, user space which doesn't support it can't even
> add a table anymore. So adding this new feature to the old code path is
> really not feasible, therefore drop this broken attempt at supporting
> it.
We fixed this problem with nft and 3.16 IIRC. So at least the very
basic featureset still available there works fine.
next prev parent reply other threads:[~2017-08-15 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 23:43 [nft PATCH 0/4] A bunch of fixes for echo output Phil Sutter
2017-08-14 23:43 ` [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls Phil Sutter
2017-08-15 10:25 ` Pablo Neira Ayuso [this message]
2017-08-15 11:05 ` Phil Sutter
2017-08-15 11:48 ` Pablo Neira Ayuso
2017-08-14 23:43 ` [nft PATCH 2/4] netlink: Fix segfault when using --echo flag Phil Sutter
2017-08-15 10:25 ` Pablo Neira Ayuso
2017-08-14 23:43 ` [nft PATCH 3/4] echo: Fix for added delays in rule updates Phil Sutter
2017-08-15 10:35 ` Pablo Neira Ayuso
2017-08-15 11:27 ` Phil Sutter
2017-08-15 11:34 ` Phil Sutter
2017-08-15 11:49 ` Pablo Neira Ayuso
2017-08-14 23:43 ` [nft PATCH 4/4] tests: Merge monitor and echo test suites Phil Sutter
2017-08-15 10:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815102500.GA3928@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).