From: Florian Westphal <fw@strlen.de>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Michal Kubecek <mkubecek@suse.cz>,
Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Markos Chandras <markos.chandras@suse.com>
Subject: Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on GSO packets
Date: Thu, 24 Aug 2017 15:17:22 +0200 [thread overview]
Message-ID: <20170824131722.GB15739@breakpoint.cc> (raw)
In-Reply-To: <1503580122.2958.37.camel@redhat.com>
Davide Caratti <dcaratti@redhat.com> wrote:
> Small nit: may I suggest you to call skb_csum_hwoffload_help() instead of
> skb_checksum_help(), so that we avoid corrupting SCTP packets in case they
> hit xt_CHECKSUM target?
Alternatively we could restrict the target to udp only.
AFAIU the only reason this thing exists is to fix up udp checksum
for old dhcp clients that use AF_PACKET without evaluating the extra
metadata that indicates when a 'bad' checksum is in fact ok because it
is supposed to be filled in by hardware later.
This can happen in virtual environemnt when such skb is directly passed
to vm.
next prev parent reply other threads:[~2017-08-24 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 10:48 [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on GSO packets Michal Kubecek
2017-08-24 10:51 ` Florian Westphal
2017-08-24 11:07 ` Michal Kubecek
2017-08-24 13:08 ` Davide Caratti
2017-08-24 13:17 ` Florian Westphal [this message]
2017-08-25 9:28 ` Michal Kubecek
2017-08-25 9:40 ` Florian Westphal
2017-08-25 9:43 ` Florian Westphal
2017-08-25 9:21 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824131722.GB15739@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=dcaratti@redhat.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=markos.chandras@suse.com \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).