From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Joe Stringer <joe@ovn.org>
Cc: Andy Zhou <azhou@ovn.org>, netfilter-devel@vger.kernel.org
Subject: Re: [patch nf] netfilter: nf_tables: Fix nft limit burst handling
Date: Thu, 24 Aug 2017 16:23:07 +0200 [thread overview]
Message-ID: <20170824142307.GA3591@salvia> (raw)
In-Reply-To: <CAPWQB7E1wLt4vuWUt8i8aqu4myxtZ81yEd7-7NVhhgiaCreKrA@mail.gmail.com>
On Mon, Aug 21, 2017 at 02:29:13PM -0700, Joe Stringer wrote:
> On 21 August 2017 at 12:38, Andy Zhou <azhou@ovn.org> wrote:
> > Fixes: 96518518cc41 ("netfilter: add nftables")
> >
> > Current implementation treats the burst configuration the same as
> > rate configuration. This can cause the per packet cost to be lower
> > than configured. In effect, this bug causes the token bucket to be
> > refilled at a higher rate than what user has specified.
> >
> > This patch changes the implementation so that the token bucket size
> > is controlled by "rate + burst", while maintain the token bucket
> > refill rate the same as user specified.
> >
> > Signed-off-by: Andy Zhou <azhou@ovn.org>
>
> Usually "Fixes" tag appears immediately above the signoff lines.
>
> This is the bug that we brought up during NFWS this year in Faro, how
> the burst was not acting as a burst but rather it just added to the
> rate.
>
> Acked-by: Joe Stringer <joe@ovn.org>
Applied, thanks a lot for this fix.
prev parent reply other threads:[~2017-08-24 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 19:38 [patch nf] netfilter: nf_tables: Fix nft limit burst handling Andy Zhou
2017-08-21 21:29 ` Joe Stringer
2017-08-24 14:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824142307.GA3591@salvia \
--to=pablo@netfilter.org \
--cc=azhou@ovn.org \
--cc=joe@ovn.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).