* [nft PATCH] Fix debug_proto_ctx()
@ 2017-08-24 16:04 Phil Sutter
2017-08-24 16:11 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2017-08-24 16:04 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
Debug mask check was done against wrong flag, causing protocol context
debug output being printed when only --debug=netlink was given.
Fixes: be441e1ffdc24 ("src: add debugging mask to context structure")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
This led to almost all testcases in tests/py to fail due to differing
output when checking netlink messages. Pablo, did you just forget to run
the testsuite, or is there a bug in your environment somewhere so this
could slip through?
---
src/proto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/proto.c b/src/proto.c
index 5bd50b7b96195..a72c10c3a1680 100644
--- a/src/proto.c
+++ b/src/proto.c
@@ -143,7 +143,7 @@ static void proto_ctx_debug(const struct proto_ctx *ctx, enum proto_bases base,
{
unsigned int i;
- if (!(debug_mask & DEBUG_NETLINK))
+ if (!(debug_mask & DEBUG_PROTO_CTX))
return;
pr_debug("update %s protocol context:\n", proto_base_names[base]);
--
2.13.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nft PATCH] Fix debug_proto_ctx()
2017-08-24 16:04 [nft PATCH] Fix debug_proto_ctx() Phil Sutter
@ 2017-08-24 16:11 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2017-08-24 16:11 UTC (permalink / raw)
To: Phil Sutter; +Cc: netfilter-devel
On Thu, Aug 24, 2017 at 06:04:18PM +0200, Phil Sutter wrote:
> Debug mask check was done against wrong flag, causing protocol context
> debug output being printed when only --debug=netlink was given.
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-24 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-24 16:04 [nft PATCH] Fix debug_proto_ctx() Phil Sutter
2017-08-24 16:11 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).