From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [conntrack-tools PATCH] tests: don't fail on modprobe since the driver might be built-in
Date: Thu, 24 Aug 2017 18:51:06 +0200 [thread overview]
Message-ID: <20170824165106.GA15078@salvia> (raw)
In-Reply-To: <150280165807.21062.1101236218834054083.stgit@nfdev2.cica.es>
On Tue, Aug 15, 2017 at 02:54:18PM +0200, Arturo Borrero Gonzalez wrote:
> From: Steve Langasek <steve.langasek@ubuntu.com>
>
> Any of these nf drivers could be built-ins instead of modules; don't cause
> the testsuite to fail on modprobe, instead let it proceed and succeed/fail
> later based on actual test results.
>
> Ideally we would check up front if the driver is loaded rather than trying
> to modprobe and ignoring failures, but there doesn't seem to be a reliable
> place to check this in the kernel filesystem.
>
> Signed-off-by: Steve Langasek <steve.langasek@ubuntu.com>
> Signed-off-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
Applied, thanks Arturo.
prev parent reply other threads:[~2017-08-24 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 12:54 [conntrack-tools PATCH] tests: don't fail on modprobe since the driver might be built-in Arturo Borrero Gonzalez
2017-08-24 16:51 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824165106.GA15078@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).