Re: [PATH nft v2 13/18] libnftables: add nft_context_set_print

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Sat, Aug 19, 2017 at 05:24:15PM +0200, Eric Leblond wrote:
> This function allows user to set his own printing function. It is
> still dependant of the format used by nft but at least it can be
> redirected easily.

I'm looking at this patch...

> Signed-off-by: Eric Leblond <eric@regit.org>
> ---
>  include/nftables/nftables.h | 3 +++
>  src/libnftables.c           | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/include/nftables/nftables.h b/include/nftables/nftables.h
> index b902cbd..935d0db 100644
> --- a/include/nftables/nftables.h
> +++ b/include/nftables/nftables.h
> @@ -26,6 +26,9 @@ void nft_global_deinit(void);
>  
>  struct nft_ctx *nft_context_new(void);
>  void nft_context_free(struct nft_ctx *nft);
> +void nft_context_set_print_func(struct nft_ctx *nft,
> +				int (*print)(void *ctx, const char *fmt, ...),
> +				void *ctx);
>  
>  int nft_run_command_from_buffer(struct nft_ctx *nft,
>  				char *buf, size_t buflen);
> diff --git a/src/libnftables.c b/src/libnftables.c
> index 7209885..f0decae 100644
> --- a/src/libnftables.c
> +++ b/src/libnftables.c
> @@ -86,6 +86,15 @@ struct nft_ctx *nft_context_new(void)
>  	return ctx;
>  }
>  
> +void nft_context_set_print_func(struct nft_ctx *nft,
> +				int (*print)(void *ctx, const char *fmt, ...),
> +				void *ctx)

Can we have a strict type here instead of void *ctx? I mean, if ctx is
always going to be a file descriptor, I would prefer this is a
specific type.

Or are you envisioning any real use of this generic type? If we cannot
forecast anything reasonable, then a strict type is the way to go IMO.