From: Phil Sutter <phil@nwl.cc>
To: Eric Leblond <eric@regit.org>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2 00/18] introducing libnftables
Date: Wed, 30 Aug 2017 12:31:32 +0200 [thread overview]
Message-ID: <20170830103132.GG20614@orbyte.nwl.cc> (raw)
In-Reply-To: <20170819152420.22563-1-eric@regit.org>
Hi,
On Sat, Aug 19, 2017 at 05:24:02PM +0200, Eric Leblond wrote:
> This patchset is the second version of libnftables introduction patchset.
> It addresses some remarks by Phil Sutter. Other remarks as said on the ML
> are in fact TODO points that can be adressed later.
So, what is the current status, please? Could we perhaps collect open
points and clarify who's working on what?
>From the top of my head, open points are:
* Where to keep nf_sock:
- Either completely separate (needs init/deinit routines for
convenience).
- Or as part of nft_ctx (needs getter/setter for advanced usage).
* Do we want global init/deinit functions, or can we put everything into
context init/deinit functions?
* How to handle object printing:
- Having a library print to stdout is probably not desired.
- Is formatting into a string for further processing by the
application sufficient?
Anything else? Are there tasks which can be done now and nobody wants so
I could take over?
Cheers, Phil
next prev parent reply other threads:[~2017-08-30 10:31 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 15:24 [PATCH nft v2 00/18] introducing libnftables Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 01/18] mnl: fix error handling in mnl_batch_talk Eric Leblond
2017-08-21 8:10 ` Pablo Neira Ayuso
2017-08-21 19:01 ` Eric Leblond
2017-08-24 15:13 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 02/18] erec: add function to free list Eric Leblond
2017-08-21 8:12 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 03/18] libnftables: introduce library Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 04/18] libnftables: add context new and free Eric Leblond
2017-08-21 8:17 ` Pablo Neira Ayuso
2017-08-24 15:30 ` Pablo Neira Ayuso
2017-08-25 11:22 ` Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 05/18] libnftables: add nft_run_command_from_buffer Eric Leblond
2017-08-21 8:23 ` Pablo Neira Ayuso
2017-08-21 8:45 ` Pablo Neira Ayuso
2017-08-21 9:06 ` Eric Leblond
2017-08-21 9:44 ` Pablo Neira Ayuso
2017-08-21 19:21 ` Eric Leblond
2017-08-22 12:37 ` Pablo Neira Ayuso
2017-08-25 11:16 ` Eric Leblond
2017-08-24 15:49 ` Pablo Neira Ayuso
2017-08-25 11:26 ` Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 06/18] libnftables: add nft_run_command_from_filename Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 07/18] libnftables: put nft_run in library Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 08/18] libnftables: add missing variables to library Eric Leblond
2017-08-21 8:27 ` Pablo Neira Ayuso
2017-08-21 19:04 ` Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 09/18] libnftables: add NFT_EXIT_* " Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 10/18] libnftables: add a nft_cache to nft_ctx Eric Leblond
2017-08-21 8:32 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 11/18] libnftables: move iface_cache_release to deinit Eric Leblond
2017-08-21 8:33 ` Pablo Neira Ayuso
2017-08-24 15:55 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 12/18] libnftables: get rid of printf Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 13/18] libnftables: add nft_context_set_print Eric Leblond
2017-08-25 9:59 ` Pablo Neira Ayuso
2017-08-25 11:49 ` Eric Leblond
2017-08-30 10:46 ` Pablo Neira Ayuso
2017-08-31 10:09 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 14/18] libnftables: transaction support Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 15/18] libnftables: set max_errors to 1 in library Eric Leblond
2017-08-21 8:37 ` Pablo Neira Ayuso
2017-08-21 19:12 ` Eric Leblond
2017-08-22 15:04 ` Phil Sutter
2017-08-24 16:02 ` Pablo Neira Ayuso
2017-08-25 11:37 ` Eric Leblond
2017-08-28 15:18 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 16/18] libnftables: add error handling Eric Leblond
2017-08-19 15:24 ` [PATH nft v2 17/18] libnftables: suppress unused global variables Eric Leblond
2017-08-21 8:40 ` Pablo Neira Ayuso
2017-08-19 15:24 ` [PATH nft v2 18/18] libnftables: doxygen documentation Eric Leblond
2017-08-21 8:55 ` [PATCH nft v2 00/18] introducing libnftables Pablo Neira Ayuso
2017-08-21 21:42 ` Eric Leblond
2017-08-22 17:30 ` Pablo Neira Ayuso
2017-08-30 10:31 ` Phil Sutter [this message]
2017-08-31 10:19 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830103132.GG20614@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).