netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@regit.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 1/2] src: add flags fo nft_ctx_new
Date: Mon, 4 Sep 2017 00:33:09 +0200	[thread overview]
Message-ID: <20170903223309.GA12383@salvia> (raw)
In-Reply-To: <20170903220356.20178-2-eric@regit.org>

On Mon, Sep 04, 2017 at 12:03:55AM +0200, Eric Leblond wrote:
> By adding flags to nft_ctx_new, we will have a minimum capabilities
> of changing the way the nft_ctx is created.
> 
> For now, this patch uses a simple value that allow the user to specify
> that he will handle netlink by himself.
> 
> Signed-off-by: Eric Leblond <eric@regit.org>
> ---
>  include/nftables.h |  4 ++++
>  src/main.c         | 20 +++++++++++---------
>  2 files changed, 15 insertions(+), 9 deletions(-)
> 
> diff --git a/include/nftables.h b/include/nftables.h
> index 5035567..7c4e93f 100644
> --- a/include/nftables.h
> +++ b/include/nftables.h
> @@ -49,8 +49,12 @@ struct nft_ctx {
>  	struct output_ctx	output;
>  	bool			check;
>  	struct nft_cache	cache;
> +	uint32_t		flags;
>  };
>  
> +#define NFT_CTX_CUSTOM_NETLINK	(1<<0)
> +#define NFT_CTX_DEFAULT		0

Better than flag, let's make this a type, ie. NFT_CTX_NETLINK is just 1.

OK?

  reply	other threads:[~2017-09-03 22:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03 22:03 [nft PATCH 0/2] libnftables preparation work Eric Leblond
2017-09-03 22:03 ` [nft PATCH 1/2] src: add flags fo nft_ctx_new Eric Leblond
2017-09-03 22:33   ` Pablo Neira Ayuso [this message]
2017-09-03 22:45     ` Pablo Neira Ayuso
2017-09-04  7:21       ` Eric Leblond
2017-09-03 22:03 ` [nft PATCH 2/2] src: get rid of printf Eric Leblond
2017-09-03 22:34   ` Pablo Neira Ayuso
2017-09-04  7:45     ` Eric Leblond
2017-09-04  7:55     ` [nft PATCH v2] libnftables preparation work Eric Leblond
2017-09-04  7:55       ` [nft PATCH v2 1/2] src: add flags fo nft_ctx_new Eric Leblond
2017-09-04 20:43         ` Pablo Neira Ayuso
2017-09-04  7:55       ` [nft PATCH v2 2/2] src: get rid of printf Eric Leblond
2017-09-04 20:43         ` Pablo Neira Ayuso
2017-09-04 20:53           ` Pablo Neira Ayuso
2017-09-04 21:23             ` Eric Leblond
2017-09-05 17:33               ` Pablo Neira Ayuso
2017-09-21 15:37             ` Phil Sutter
2017-09-21 15:43               ` Florian Westphal
2017-09-21 15:51                 ` Pablo Neira Ayuso
2017-09-21 16:21                   ` Phil Sutter
2017-09-21 17:05                     ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170903223309.GA12383@salvia \
    --to=pablo@netfilter.org \
    --cc=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).