From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Pablo M. Bermudo Garay" <pablombg@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 1/3] netfilter: nf_tables: add select_ops for stateful objects
Date: Mon, 4 Sep 2017 13:13:33 +0200 [thread overview]
Message-ID: <20170904111333.GA29836@salvia> (raw)
In-Reply-To: <20170823204125.31427-1-pablombg@gmail.com>
On Wed, Aug 23, 2017 at 10:41:23PM +0200, Pablo M. Bermudo Garay wrote:
> This patch adds support for overloading stateful objects operations
> through the select_ops() callback, just as it is implemented for
> expressions.
>
> This change is needed for upcoming additions to the stateful objects
> infrastructure.
Applied with changes, see below.
>
> Signed-off-by: Pablo M. Bermudo Garay <pablombg@gmail.com>
> ---
> include/net/netfilter/nf_tables.h | 30 ++++++++++++++++++++++--------
> net/netfilter/nf_tables_api.c | 27 ++++++++++++++++++++-------
> net/netfilter/nft_counter.c | 12 ++++++++----
> net/netfilter/nft_ct.c | 12 ++++++++----
> net/netfilter/nft_objref.c | 4 ++--
> net/netfilter/nft_quota.c | 12 ++++++++----
> 6 files changed, 68 insertions(+), 29 deletions(-)
>
> diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
> index f9795fe394f3..b53639af1c7b 100644
> --- a/include/net/netfilter/nf_tables.h
> +++ b/include/net/netfilter/nf_tables.h
> @@ -1008,6 +1008,7 @@ int nft_verdict_dump(struct sk_buff *skb, int type,
> * @list: table stateful object list node
> * @table: table this object belongs to
> * @type: pointer to object type
> + * @ops: object operations
> * @data: pointer to object data
> * @name: name of this stateful object
> * @genmask: generation mask
> @@ -1022,6 +1023,7 @@ struct nft_object {
> use:30;
> /* runtime data below here */
> const struct nft_object_type *type ____cacheline_aligned;
> + const struct nft_object_ops *ops;
We can just leave *ops here, and place *type in nft_object_ops.
No need to rework this, I have mangled this patch here.
prev parent reply other threads:[~2017-09-04 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 20:41 [PATCH nf-next 1/3] netfilter: nf_tables: add select_ops for stateful objects Pablo M. Bermudo Garay
2017-08-23 20:41 ` [PATCH nf-next 2/3] netfilter: nft_limit: replace pkt_bytes with bytes Pablo M. Bermudo Garay
2017-09-04 11:15 ` Pablo Neira Ayuso
2017-08-23 20:41 ` [PATCH nf-next 3/3] netfilter: nft_limit: add stateful object type Pablo M. Bermudo Garay
2017-09-04 11:16 ` Pablo Neira Ayuso
2017-09-04 11:13 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904111333.GA29836@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablombg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).