From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [nft PATCH v2 2/2] src: get rid of printf Date: Mon, 4 Sep 2017 22:53:04 +0200 Message-ID: <20170904205304.GA14816@salvia> References: <20170903223441.GB12383@salvia> <20170904075558.10129-1-eric@regit.org> <20170904075558.10129-3-eric@regit.org> <20170904204348.GB14434@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Eric Leblond Return-path: Received: from ganesha.gnumonks.org ([213.95.27.120]:50095 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbdIDUxc (ORCPT ); Mon, 4 Sep 2017 16:53:32 -0400 Content-Disposition: inline In-Reply-To: <20170904204348.GB14434@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Sep 04, 2017 at 10:43:48PM +0200, Pablo Neira Ayuso wrote: > On Mon, Sep 04, 2017 at 09:55:58AM +0200, Eric Leblond wrote: > > This patch introduces the nft_print function that has to be used > > instead of printf to output information that were previously send > > to stdout. This function accumulate the output in a buffer that can > > be fetched by the user with the nft_ctx_get_output() function. > > > > This modification will allow the libnftables library to provide an > > easy way to the users to get the output data and display them like > > they want. > > tests/shell/./run-tests > > is reporting problems with this :-( Eric, I can also see there are missing printf() to nft_print() conversion on the monitor side. I would expect the simple API works like this: if you pass the "monitor" command, it justs prints events to whatever destination you have specified. This is the most simple integration that makes sense to me. Therefore, I think it would be good to convert those too to use nft_print(). Let me know, thanks.