From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/4] netfilter: ipset: ipset list may return wrong member count for set with timeout
Date: Mon, 18 Sep 2017 17:35:09 +0200 [thread overview]
Message-ID: <20170918153509.GA2177@salvia> (raw)
In-Reply-To: <1505159560-13161-5-git-send-email-kadlec@blackhole.kfki.hu>
On Mon, Sep 11, 2017 at 09:52:40PM +0200, Jozsef Kadlecsik wrote:
> From: Vishwanath Pai <vpai@akamai.com>
>
> Simple testcase:
>
> $ ipset create test hash:ip timeout 5
> $ ipset add test 1.2.3.4
> $ ipset add test 1.2.2.2
> $ sleep 5
>
> $ ipset l
> Name: test
> Type: hash:ip
> Revision: 5
> Header: family inet hashsize 1024 maxelem 65536 timeout 5
> Size in memory: 296
> References: 0
> Number of entries: 2
> Members:
>
> We return "Number of entries: 2" but no members are listed. That is
> because mtype_list runs "ip_set_timeout_expired" and does not list the
> expired entries, but set->elements is never upated (until mtype_gc
> cleans it up later).
Applied to nf.git. Thanks Jozsef.
next prev parent reply other threads:[~2017-09-18 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 19:52 [PATCH 0/4] ipset patches for nf-next Jozsef Kadlecsik
2017-09-11 19:52 ` [PATCH 1/4] netfilter: ipset: Compress return logic Jozsef Kadlecsik
2017-09-11 19:52 ` [PATCH 2/4] netfilter: ipset: Fix sparse warnings Jozsef Kadlecsik
2017-09-11 19:52 ` [PATCH 3/4] netfilter: ipset: deduplicate prefixlen maps Jozsef Kadlecsik
2017-09-11 19:52 ` [PATCH 4/4] netfilter: ipset: ipset list may return wrong member count for set with timeout Jozsef Kadlecsik
2017-09-18 15:35 ` Pablo Neira Ayuso [this message]
2017-09-18 12:30 ` [PATCH 0/4] ipset patches for nf-next Pablo Neira Ayuso
2017-09-18 18:31 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918153509.GA2177@salvia \
--to=pablo@netfilter.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).