From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 1/2] ip{,6}tables-restore: Don't ignore missing wait-interval value
Date: Wed, 20 Sep 2017 19:34:35 +0200 [thread overview]
Message-ID: <20170920173436.20221-2-phil@nwl.cc> (raw)
In-Reply-To: <20170920173436.20221-1-phil@nwl.cc>
Passing -W without a value doesn't make sense so bail out if none was
given.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
iptables/xshared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/iptables/xshared.c b/iptables/xshared.c
index 825479c338214..06db72d427e21 100644
--- a/iptables/xshared.c
+++ b/iptables/xshared.c
@@ -343,7 +343,7 @@ void parse_wait_interval(int argc, char *argv[], struct timeval *wait_interval)
else if (xs_has_arg(argc, argv))
arg = argv[optind++];
else
- return;
+ xtables_error(PARAMETER_PROBLEM, "wait interval value required");
ret = sscanf(arg, "%u", &usec);
if (ret == 1) {
--
2.13.1
next prev parent reply other threads:[~2017-09-20 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 17:34 [iptables PATCH 0/2] ip{,6}tables-restore: Fix wait-interval parsing Phil Sutter
2017-09-20 17:34 ` Phil Sutter [this message]
2017-09-20 17:34 ` [iptables PATCH 2/2] ip{,6}tables-restore: Don't accept wait-interval without wait Phil Sutter
2017-10-04 14:10 ` [iptables PATCH 0/2] ip{,6}tables-restore: Fix wait-interval parsing Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920173436.20221-2-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).