From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] monitor: Fix for incorrect debug_mask
Date: Wed, 27 Sep 2017 14:11:21 +0200 [thread overview]
Message-ID: <20170927121121.GA21470@salvia> (raw)
In-Reply-To: <20170921183802.27797-1-phil@nwl.cc>
On Thu, Sep 21, 2017 at 08:38:02PM +0200, Phil Sutter wrote:
> The field 'debug_mask' of struct netlink_mon_handler was left
> uninitialized in do_command_monitor() so it contained garbage from the
> stack. Fix this by initializing it with the debug_mask value from struct
> netlink_ctx.
>
> While being at it, change the code to make use of C99-style initializer,
> which will also avoid things like this in future.
Applied, thanks Phil.
prev parent reply other threads:[~2017-09-27 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:38 [nft PATCH] monitor: Fix for incorrect debug_mask Phil Sutter
2017-09-27 12:11 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927121121.GA21470@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).