netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/10] nftables remove use of meta nfproto
Date: Fri, 29 Sep 2017 12:24:34 +0200	[thread overview]
Message-ID: <20170929102434.GA2654@salvia> (raw)
In-Reply-To: <20170927181654.3129-1-fw@strlen.de>

On Wed, Sep 27, 2017 at 08:16:44PM +0200, Florian Westphal wrote:
> inet family (and others, e.g. bridge) lack context to figure
> out the layer 3 address type.
> 
> examples:
> ct original saddr $addr
> rt nexthop $addr
> 
> We can't use $addr, because it might be a set reference, e.g.
> 
> ct original saddr @whitelist
> 
> currently implemented workaround is to use 'meta nfproto'
> to provide the l3 context, e.g.
> 
> meta nfproto ip rt nexthop 10.2.3.4
> 
> i.e. users need to fill dependency manually.
> 
> Pablo suggested to instead specify ip saddr, ip6 saddr:
> 
> ct original ip saddr $address
> 
> and then let nft handle the dependency injection.
> 
> This series does just that.
> 
> Old syntax is preserved.

Nice series, thanks Florian.

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

      parent reply	other threads:[~2017-09-29 10:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 18:16 [PATCH nft 0/10] nftables remove use of meta nfproto Florian Westphal
2017-09-27 18:16 ` [PATCH nft 01/10] src: add alternate syntax for ct saddr Florian Westphal
2017-09-27 18:16 ` [PATCH nft 02/10] src: ct: store proto base of ct key, if any Florian Westphal
2017-09-27 18:16 ` [PATCH nft 03/10] src: ct: add eval part to inject dependencies for ct saddr/daddr Florian Westphal
2017-09-27 18:16 ` [PATCH nft 04/10] src: unifiy meta and ct postprocessing Florian Westphal
2017-09-27 18:16 ` [PATCH nft 05/10] tests: update inet/bridge icmp test case Florian Westphal
2017-09-27 18:16 ` [PATCH nft 06/10] src: ct: print nfproto name for some header fields Florian Westphal
2017-09-27 18:16 ` [PATCH nft 07/10] tests: ct: adjust test case commands Florian Westphal
2017-09-27 18:16 ` [PATCH nft 08/10] src: rt: add keyword distinction for nexthop vs nexthop6 Florian Westphal
2017-09-27 18:16 ` [PATCH nft 09/10] tests: rt: fix test cases Florian Westphal
2017-09-27 18:16 ` [PATCH nft 10/10] doc: update man page Florian Westphal
2017-09-29 10:24 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929102434.GA2654@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).