From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH v2] netfilter: SYNPROXY: fix process non tcp packet bug in {ipv4,ipv6}_synproxy_hook Date: Tue, 3 Oct 2017 15:28:25 +0200 Message-ID: <20171003132825.GA11182@salvia> References: <1506767115-10051-1-git-send-email-xiaolou4617@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org To: Lin Zhang Return-path: Received: from [213.95.27.120] ([213.95.27.120]:39812 "EHLO ganesha.gnumonks.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdJCN3l (ORCPT ); Tue, 3 Oct 2017 09:29:41 -0400 Content-Disposition: inline In-Reply-To: <1506767115-10051-1-git-send-email-xiaolou4617@gmail.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, Sep 30, 2017 at 06:25:15PM +0800, Lin Zhang wrote: > In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, > but the real server maybe reply an icmp error packet related to the > exist tcp conntrack, so we will access wrong tcp data. > > For fix it, check for the protocol field and only process tcp traffic. Applied, thanks. I have made minor comestic changes to patch title: netfilter: SYNPROXY: skip non-TCP packets from {ipv4,ipv6}_synproxy_hook for the record.