Re: [PATCH] iptables: change large file support handling

[Juergen Borleis <jbe@pengutronix.de>]

Hi Pablo,

On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:
> > > > The configure script handles the "--*-largefile" parameter badly.
> > > > It defaults to large file support if not given and always disables
> > > > largefile support if given (and it doesn't matter if 'enable' or
> > > > 'disable' was used)
> > >
> > > It seems the default behaviour for a while has been to enable
> > > largefile by default.
> > >
> > > Then, someone came in to add this --disable-largefile configure time
> > > option, see:
> > >
> > > commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> > > Author: Karl Hiramoto <karl@hiramoto.org>
> > > Date:   Mon May 10 17:50:41 2010 +0200
> > >
> > >     iptables: optionally disable largefile support
> > >
> > > So I would just fix --enable-* --disable-*.
> > >
> > > Would you follow up on this? Let me know, thanks.
> >
> > With my change the default is still "enabled" and you can disable it on
> > demand.
>
> I'm going to remove this from your log message: "It defaults to large
> file support if not given", when I read this I thought this was the
> problem.

Ahh, okay.

Juergen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Linux Solutions for Science and Industry     | Phone: +49-5121-206917-5128 |
Peiner Str. 6-8, 31137 Hildesheim, Germany   | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686             | http://www.pengutronix.de/  |