* [PATCH] iptables: change large file support handling
@ 2017-09-28 8:59 Juergen Borleis
2017-10-04 14:14 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Borleis @ 2017-09-28 8:59 UTC (permalink / raw)
To: netfilter-devel
The configure script handles the "--*-largefile" parameter badly. It
defaults to large file support if not given and always disables largefile
support if given (and it doesn't matter if 'enable' or 'disable' was used)
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
configure.ac | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index eda7871405b3..30445d7deda8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -42,8 +42,9 @@ AC_ARG_ENABLE([ipv6],
AC_ARG_ENABLE([largefile],
AS_HELP_STRING([--disable-largefile], [Do not build largefile support]),
[enable_largefile="$enableval"],
- [enable_largefile="yes";
- largefile_cppflags='-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64'])
+ [enable_largefile="yes"])
+AS_IF([test "$enable_largefile" = "yes"], [largefile_cppflags='-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64'])
+
AC_ARG_ENABLE([devel],
AS_HELP_STRING([--enable-devel],
[Install Xtables development headers]),
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iptables: change large file support handling
2017-09-28 8:59 [PATCH] iptables: change large file support handling Juergen Borleis
@ 2017-10-04 14:14 ` Pablo Neira Ayuso
2017-10-04 14:39 ` Juergen Borleis
0 siblings, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2017-10-04 14:14 UTC (permalink / raw)
To: Juergen Borleis; +Cc: netfilter-devel
Hi Juergen,
On Thu, Sep 28, 2017 at 10:59:44AM +0200, Juergen Borleis wrote:
> The configure script handles the "--*-largefile" parameter badly. It
> defaults to large file support if not given and always disables largefile
> support if given (and it doesn't matter if 'enable' or 'disable' was used)
It seems the default behaviour for a while has been to enable
largefile by default.
Then, someone came in to add this --disable-largefile configure time
option, see:
commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
Author: Karl Hiramoto <karl@hiramoto.org>
Date: Mon May 10 17:50:41 2010 +0200
iptables: optionally disable largefile support
So I would just fix --enable-* --disable-*.
Would you follow up on this? Let me know, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iptables: change large file support handling
2017-10-04 14:14 ` Pablo Neira Ayuso
@ 2017-10-04 14:39 ` Juergen Borleis
2017-10-04 14:46 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Borleis @ 2017-10-04 14:39 UTC (permalink / raw)
To: netfilter-devel; +Cc: Pablo Neira Ayuso
Hi Pablo,
On Wednesday 04 October 2017 16:14:58 Pablo Neira Ayuso wrote:
> > The configure script handles the "--*-largefile" parameter badly. It
> > defaults to large file support if not given and always disables
> > largefile support if given (and it doesn't matter if 'enable' or
> > 'disable' was used)
>
> It seems the default behaviour for a while has been to enable
> largefile by default.
>
> Then, someone came in to add this --disable-largefile configure time
> option, see:
>
> commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> Author: Karl Hiramoto <karl@hiramoto.org>
> Date: Mon May 10 17:50:41 2010 +0200
>
> iptables: optionally disable largefile support
>
> So I would just fix --enable-* --disable-*.
>
> Would you follow up on this? Let me know, thanks.
With my change the default is still "enabled" and you can disable it on
demand. To have still support for "disable on demand" makes sense for some
small 32 bit embedded systems.
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iptables: change large file support handling
2017-10-04 14:39 ` Juergen Borleis
@ 2017-10-04 14:46 ` Pablo Neira Ayuso
2017-10-04 14:52 ` Juergen Borleis
0 siblings, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2017-10-04 14:46 UTC (permalink / raw)
To: Juergen Borleis; +Cc: netfilter-devel
On Wed, Oct 04, 2017 at 04:39:23PM +0200, Juergen Borleis wrote:
> Hi Pablo,
>
> On Wednesday 04 October 2017 16:14:58 Pablo Neira Ayuso wrote:
> > > The configure script handles the "--*-largefile" parameter badly. It
> > > defaults to large file support if not given and always disables
> > > largefile support if given (and it doesn't matter if 'enable' or
> > > 'disable' was used)
> >
> > It seems the default behaviour for a while has been to enable
> > largefile by default.
> >
> > Then, someone came in to add this --disable-largefile configure time
> > option, see:
> >
> > commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> > Author: Karl Hiramoto <karl@hiramoto.org>
> > Date: Mon May 10 17:50:41 2010 +0200
> >
> > iptables: optionally disable largefile support
> >
> > So I would just fix --enable-* --disable-*.
> >
> > Would you follow up on this? Let me know, thanks.
>
> With my change the default is still "enabled" and you can disable it on
> demand.
I'm going to remove this from your log message: "It defaults to large
file support if not given", when I read this I thought this was the
problem.
> To have still support for "disable on demand" makes sense for some
> small 32 bit embedded systems.
Sure, this knob is useful, not questioning this, and it needs to be
fixed.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iptables: change large file support handling
2017-10-04 14:46 ` Pablo Neira Ayuso
@ 2017-10-04 14:52 ` Juergen Borleis
2017-10-04 15:09 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Borleis @ 2017-10-04 14:52 UTC (permalink / raw)
To: netfilter-devel; +Cc: Pablo Neira Ayuso
Hi Pablo,
On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:
> > > > The configure script handles the "--*-largefile" parameter badly.
> > > > It defaults to large file support if not given and always disables
> > > > largefile support if given (and it doesn't matter if 'enable' or
> > > > 'disable' was used)
> > >
> > > It seems the default behaviour for a while has been to enable
> > > largefile by default.
> > >
> > > Then, someone came in to add this --disable-largefile configure time
> > > option, see:
> > >
> > > commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> > > Author: Karl Hiramoto <karl@hiramoto.org>
> > > Date: Mon May 10 17:50:41 2010 +0200
> > >
> > > iptables: optionally disable largefile support
> > >
> > > So I would just fix --enable-* --disable-*.
> > >
> > > Would you follow up on this? Let me know, thanks.
> >
> > With my change the default is still "enabled" and you can disable it on
> > demand.
>
> I'm going to remove this from your log message: "It defaults to large
> file support if not given", when I read this I thought this was the
> problem.
Ahh, okay.
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Linux Solutions for Science and Industry | Phone: +49-5121-206917-5128 |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iptables: change large file support handling
2017-10-04 14:52 ` Juergen Borleis
@ 2017-10-04 15:09 ` Pablo Neira Ayuso
0 siblings, 0 replies; 6+ messages in thread
From: Pablo Neira Ayuso @ 2017-10-04 15:09 UTC (permalink / raw)
To: Juergen Borleis; +Cc: netfilter-devel
On Wed, Oct 04, 2017 at 04:52:05PM +0200, Juergen Borleis wrote:
> Hi Pablo,
>
> On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:
> > > > > The configure script handles the "--*-largefile" parameter badly.
> > > > > It defaults to large file support if not given and always disables
> > > > > largefile support if given (and it doesn't matter if 'enable' or
> > > > > 'disable' was used)
> > > >
> > > > It seems the default behaviour for a while has been to enable
> > > > largefile by default.
> > > >
> > > > Then, someone came in to add this --disable-largefile configure time
> > > > option, see:
> > > >
> > > > commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> > > > Author: Karl Hiramoto <karl@hiramoto.org>
> > > > Date: Mon May 10 17:50:41 2010 +0200
> > > >
> > > > iptables: optionally disable largefile support
> > > >
> > > > So I would just fix --enable-* --disable-*.
> > > >
> > > > Would you follow up on this? Let me know, thanks.
> > >
> > > With my change the default is still "enabled" and you can disable it on
> > > demand.
> >
> > I'm going to remove this from your log message: "It defaults to large
> > file support if not given", when I read this I thought this was the
> > problem.
>
> Ahh, okay.
Now applied, thanks for explaining.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-04 15:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-28 8:59 [PATCH] iptables: change large file support handling Juergen Borleis
2017-10-04 14:14 ` Pablo Neira Ayuso
2017-10-04 14:39 ` Juergen Borleis
2017-10-04 14:46 ` Pablo Neira Ayuso
2017-10-04 14:52 ` Juergen Borleis
2017-10-04 15:09 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).