From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] evaluate: Fix debug output
Date: Fri, 6 Oct 2017 14:36:13 +0200 [thread overview]
Message-ID: <20171006123613.GA4713@salvia> (raw)
In-Reply-To: <20171004135932.20773-1-phil@nwl.cc>
On Wed, Oct 04, 2017 at 03:59:32PM +0200, Phil Sutter wrote:
> When introducing output_fp, debug output in src/evaluate.c was not
> adjusted and therefore broke.
>
> This patch restores eval debug output by applying the following changes:
>
> - Change erec_print() and erec_print_list() to take a struct output_ctx
> pointer as first argument and use output_fp field as destination to
> print to.
> - Drop octx_debug_dummy variable and instead use octx pointer from
> struct eval_ctx for debug output.
> - Add missing calls to erec_destroy() in eval debug output which should
> eliminate another mem leak.
OK, I'll pick this one and we go for release.
Applied, thanks.
prev parent reply other threads:[~2017-10-06 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 13:59 [nft PATCH] evaluate: Fix debug output Phil Sutter
2017-10-06 12:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006123613.GA4713@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).