From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: man page nft.8 add chain synopsis
Date: Fri, 6 Oct 2017 14:52:50 +0200 [thread overview]
Message-ID: <20171006125250.GA7768@salvia> (raw)
In-Reply-To: <20171006050838.GA9956@dimstar.local.net>
Hi Duncan,
On Fri, Oct 06, 2017 at 04:08:38PM +1100, Duncan Roe wrote:
> Hi,
>
> The man page says this:
>
> > {add | create} chain [family] table chain [ { {type} {hook} [device] {priority} } [policy] ]
>
> But I suggest it should say this:
>
> > {add | create} chain [family] table chain [ { {type} {hook} [device] {priority ;} [policy ;] } ]
>
> i.e. the policy tuple should be inside the braces along with type, hook, device
> & priority. Also the device & priority tuples each need to be followed by a
> semicolon.
>
> ** Is the above change correct?
This looks good to me.
I will include your Signed-off-by tag and will take this into the git
tree.
BTW, please next time submit your patches via git format-patch.
> * Assuming it is correct, the patch below makes the change. Can someone pick it
> up from here or should I submit a bug report?
I'll pick it, no need for bug report.
Thanks!
prev parent reply other threads:[~2017-10-06 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 5:08 man page nft.8 add chain synopsis Duncan Roe
2017-10-06 12:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006125250.GA7768@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).