man page nft.8 add chain synopsis

man page nft.8 add chain synopsis

[Duncan Roe]

Hi,

The man page says this:

> {add | create} chain [family] table chain [ { {type} {hook} [device] {priority} } [policy] ]

But I suggest it should say this:

> {add | create} chain [family] table chain [ { {type} {hook} [device] {priority ;} [policy ;] } ]

i.e. the policy tuple should be inside the braces along with type, hook, device
& priority. Also the device & priority tuples each need to be followed by a
semicolon.

** Is the above change correct?

* Assuming it is correct, the patch below makes the change. Can someone pick it
  up from here or should I submit a bug report?

Cheers ... Duncan.

---

diff --git a/doc/nft.xml b/doc/nft.xml
index c0f42dd..80ffcd7 100644
--- a/doc/nft.xml
+++ b/doc/nft.xml
@@ -664,9 +664,9 @@ filter input iif $int_ifs accept
						<arg choice="req"><replaceable>type</replaceable></arg>
						<arg choice="req"><replaceable>hook</replaceable></arg>
						<arg choice="opt"><replaceable>device</replaceable></arg>
-						<arg choice="req"><replaceable>priority</replaceable></arg>
+						<arg choice="req"><replaceable>priority</replaceable> ;</arg>
+						<arg choice="opt"><replaceable>policy</replaceable> ;</arg>
					</arg>
-					<arg choice="opt"><replaceable>policy</replaceable></arg>
				</arg>
			</cmdsynopsis>
			<cmdsynopsis>

Re: man page nft.8 add chain synopsis

[Pablo Neira Ayuso]

Hi Duncan,

On Fri, Oct 06, 2017 at 04:08:38PM +1100, Duncan Roe wrote:
> Hi,
> 
> The man page says this:
> 
> > {add | create} chain [family] table chain [ { {type} {hook} [device] {priority} } [policy] ]
> 
> But I suggest it should say this:
> 
> > {add | create} chain [family] table chain [ { {type} {hook} [device] {priority ;} [policy ;] } ]
> 
> i.e. the policy tuple should be inside the braces along with type, hook, device
> & priority. Also the device & priority tuples each need to be followed by a
> semicolon.
> 
> ** Is the above change correct?

This looks good to me.

I will include your Signed-off-by tag and will take this into the git
tree.

BTW, please next time submit your patches via git format-patch.

> * Assuming it is correct, the patch below makes the change. Can someone pick it
>   up from here or should I submit a bug report?

I'll pick it, no need for bug report.

Thanks!