netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: netfilter-devel@vger.kernel.org,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH] tests: shell: add testcases for named objects
Date: Mon, 9 Oct 2017 14:02:33 +0200	[thread overview]
Message-ID: <20171009120233.GA7926@salvia> (raw)
In-Reply-To: <CANMOCy0E1zpo_0ajtf0jvvZ7oGB1YKtQNkHAK8wEViiaVnsZ8Q@mail.gmail.com>

On Sat, Oct 07, 2017 at 01:11:17PM +0530, Harsha Sharma wrote:
> On Fri, Oct 6, 2017 at 6:08 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Oct 05, 2017 at 03:45:39PM +0530, Harsha Sharma wrote:
> >> Add testcases for creating named objects with unique name, defined
> >> by user and referencing them from rule.
> >
> > Also applied, thanks.
> >
> > Could you add another tests for 'limit' objects too? I think I posted
> > an example to the mailing list.
> 
> Hello,
> I have pulled to latest tree, then make and make installed all changes
> but still I'm unable to add named 'limit' objects. If there is something that
> I'm missing, please let me know.

Are you using a kernel compiled from nf.git tree?

> Can you also please suggest some more tasks ?

Yes. It would be great if you could update tests/py/nft-tests.py to
add a new option, basically to take all tests from files, place them
in a file and exercise the 'nft -f' path with such an autogenerated
large file with all tests.

Would you have a look into that?

Thanks.

  reply	other threads:[~2017-10-09 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 10:15 [PATCH] tests: shell: add testcases for named objects Harsha Sharma
2017-10-06 12:38 ` Pablo Neira Ayuso
2017-10-07  7:41   ` Harsha Sharma
2017-10-09 12:02     ` Pablo Neira Ayuso [this message]
2017-10-09 12:33       ` Harsha Sharma
2017-10-10 20:40       ` Harsha Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009120233.GA7926@salvia \
    --to=pablo@netfilter.org \
    --cc=harshasharmaiitr@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).