From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] tests: shell: add testcases for named objects Date: Mon, 9 Oct 2017 14:02:33 +0200 Message-ID: <20171009120233.GA7926@salvia> References: <20171005101539.32010-1-harshasharmaiitr@gmail.com> <20171006123835.GC4713@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, outreachy-kernel To: Harsha Sharma Return-path: Received: from ganesha.gnumonks.org ([213.95.27.120]:40295 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdJIMCm (ORCPT ); Mon, 9 Oct 2017 08:02:42 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, Oct 07, 2017 at 01:11:17PM +0530, Harsha Sharma wrote: > On Fri, Oct 6, 2017 at 6:08 PM, Pablo Neira Ayuso wrote: > > On Thu, Oct 05, 2017 at 03:45:39PM +0530, Harsha Sharma wrote: > >> Add testcases for creating named objects with unique name, defined > >> by user and referencing them from rule. > > > > Also applied, thanks. > > > > Could you add another tests for 'limit' objects too? I think I posted > > an example to the mailing list. > > Hello, > I have pulled to latest tree, then make and make installed all changes > but still I'm unable to add named 'limit' objects. If there is something that > I'm missing, please let me know. Are you using a kernel compiled from nf.git tree? > Can you also please suggest some more tasks ? Yes. It would be great if you could update tests/py/nft-tests.py to add a new option, basically to take all tests from files, place them in a file and exercise the 'nft -f' path with such an autogenerated large file with all tests. Would you have a look into that? Thanks.