From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/9] tests: Move tests from files to shell.
Date: Tue, 17 Oct 2017 13:08:10 +0200 [thread overview]
Message-ID: <20171017110810.GA24278@salvia> (raw)
In-Reply-To: <CAAFX7JTjwwp+pCLW6MtD6nVuq7wA4-EZVssGvEO3QOkxBnXNOQ@mail.gmail.com>
On Sat, Oct 14, 2017 at 06:34:28PM +0530, Varsha Rao wrote:
> Hello Pablo,
>
> On Wed, Oct 11, 2017 at 3:27 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hi Varsha,
> >
> > On Wed, Oct 11, 2017 at 10:03:56AM +0530, Varsha Rao wrote:
> >> Test files of tests/files/ are moved to tests/shell.
> >
> > We have more than 100 tests these days, could you have a look at the
> > repository to see if this is adding redundant tests for what we have?
> > If we already have a test covering the same configuration, we should
> > just remove them from tests/files/.
> >
> Sorry, the cover letter title and commit message looks misleading.
> But I have removed the redundant ones and added tests which were
> not there.
Thanks for clarifying, I have applied this.
prev parent reply other threads:[~2017-10-17 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 4:33 [PATCH nft 0/9] tests: Move tests from files to shell Varsha Rao
2017-10-11 4:37 ` [PATCH nft 1/9] tests: files: Remove jump chain tests Varsha Rao
2017-10-11 4:41 ` [PATCH nft 2/9] tests: shell: Add test case for jump chain Varsha Rao
2017-10-11 4:44 ` [PATCH nft 3/9] tests: shell: Add test case for sets Varsha Rao
2017-10-11 4:47 ` [PATCH nft 4/9] tests: files: Remove tests for set Varsha Rao
2017-10-11 4:51 ` [PATCH nft 5/9] tests: shell: Add tests for variable definition Varsha Rao
2017-10-11 4:53 ` [PATCH nft 6/9] tests: files: Remove test cases " Varsha Rao
2017-10-11 4:56 ` [PATCH nft 7/9] tests: files: Remove tests for chain Varsha Rao
2017-10-11 4:59 ` [PATCH nft 8/9] tests: files: Remove tests for table Varsha Rao
2017-10-11 5:01 ` [PATCH nft 9/9] tests: files: Remove tests for verdict maps Varsha Rao
2017-10-11 9:57 ` [PATCH nft 0/9] tests: Move tests from files to shell Pablo Neira Ayuso
2017-10-14 13:04 ` Varsha Rao
2017-10-17 11:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017110810.GA24278@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).