netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: netfilter-devel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] tests: xlate: print tests passed and error for testfile argument
Date: Tue, 17 Oct 2017 13:27:57 +0200	[thread overview]
Message-ID: <20171017112757.GA8578@salvia> (raw)
In-Reply-To: <20171017092458.18672-1-harshasharmaiitr@gmail.com>

On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
> Print tests passed with errors and warnings when run with only specified
> test file.

I would expect this works like this, for consistency with other test
infrastructure we have:

# python xlate-test.py extensions/libxt_ecn.txlate 
Error: test file does not exist

I can see here this works like this:

# python xlate-test.py libxt_ecn.txlate 

But as said, it is counterintuitive. Would you revisit this patch?

Thanks.

  reply	other threads:[~2017-10-17 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17  9:24 [PATCH v2] tests: xlate: print tests passed and error for testfile argument Harsha Sharma
2017-10-17 11:27 ` Pablo Neira Ayuso [this message]
2017-10-17 12:41   ` Harsha Sharma
2017-10-17 12:44     ` Pablo Neira Ayuso
2017-10-17 12:45       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017112757.GA8578@salvia \
    --to=pablo@netfilter.org \
    --cc=harshasharmaiitr@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).