From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] rule: fix netlink debug flag when listing table/rules
Date: Thu, 19 Oct 2017 11:56:59 +0200 [thread overview]
Message-ID: <20171019095659.GA2089@salvia> (raw)
In-Reply-To: <20171018230607.22375-1-fw@strlen.de>
On Thu, Oct 19, 2017 at 01:06:07AM +0200, Florian Westphal wrote:
> nft --debug=netlink list table ...
> has no effect anymore.
>
> Callers pass in debug_mask & DEBUG_NETLINK, which gets converted
> to 0/1 because the arg is a boolean.
>
> Later on this bool is converted back to an integer, but that
> won't have the desired result.
>
> Fixes: be441e1ffdc24 ("src: add debugging mask to context structure")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2017-10-19 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 23:06 [PATCH nft] rule: fix netlink debug flag when listing table/rules Florian Westphal
2017-10-19 9:56 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019095659.GA2089@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).