From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: netfilter-devel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] tests: xlate: print total no. of testfiles, tests and tests passed
Date: Thu, 19 Oct 2017 12:33:57 +0200 [thread overview]
Message-ID: <20171019103357.GA2716@salvia> (raw)
In-Reply-To: <20171018142944.14872-1-harshasharmaiitr@gmail.com>
On Wed, Oct 18, 2017 at 07:59:44PM +0530, Harsha Sharma wrote:
> Print errors and total no of tests and tests passed for testfile argument.
> Print total no. of testfiles, total no. of tests and total no. of tests
> passed for "all" argument.
> Change testfile argument to take "extensions/test_file" as argument.
Looks good, but general rule is:
One logical change per patch.
I mean, this patch description says you're doing two things:
1) Print errors and total no of tests and tests passed for testfile
argument.
2) Change testfile argument to take "extensions/test_file" as
argument.
This means you have to send two patches, one for #1, and another one
for #2.
If you do so, git becomes way more useful when doing archeology, since
we know what patch added what single thing.
next prev parent reply other threads:[~2017-10-19 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 14:29 [PATCH] tests: xlate: print total no. of testfiles, tests and tests passed Harsha Sharma
2017-10-19 10:33 ` Pablo Neira Ayuso [this message]
2017-10-19 10:35 ` Pablo Neira Ayuso
2017-10-19 12:51 ` Harsha Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019103357.GA2716@salvia \
--to=pablo@netfilter.org \
--cc=harshasharmaiitr@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).