From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Eric Leblond <eric@regit.org>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [nft PATCH v2 1/4] libnftables: Move library stuff out of main.c
Date: Tue, 24 Oct 2017 18:42:31 +0200 [thread overview]
Message-ID: <20171024164231.GQ32305@orbyte.nwl.cc> (raw)
In-Reply-To: <20171024154800.GA11705@salvia>
Hi Pablo,
On Tue, Oct 24, 2017 at 05:48:00PM +0200, Pablo Neira Ayuso wrote:
> On Mon, Oct 23, 2017 at 05:33:16PM +0200, Phil Sutter wrote:
[...]
> > +/**
> > + * Exit codes returned by nft_run_cmd_from_*()
> > + */
> > +enum nftables_exit_codes {
> > + NFT_EXIT_SUCCESS = 0,
> > + NFT_EXIT_FAILURE = 1,
> > + NFT_EXIT_NOMEM = 2,
> > + NFT_EXIT_NONL = 3,
> > +};
>
> I think library is currently aborting in case of no-netlink and
> no-memory, so these two error codes are not useful.
>
> We would need to change codebase to propagate errors up to the
> callers.
Ah yes, indeed. I guess for a library, calling exit() is a no-go. :)
> Regarding error code, I would go for -1 in case of error instead and 0
> in case of success. If failure happens, then set errno with reason, so
> we can get rid of these exit codes in a follow up patch?
Sounds good, I'll send a follow-up.
Thanks, Phil
next prev parent reply other threads:[~2017-10-24 16:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 15:33 [nft PATCH v2 0/4] libnftables preparations Phil Sutter
2017-10-23 15:33 ` [nft PATCH v2 1/4] libnftables: Move library stuff out of main.c Phil Sutter
2017-10-24 15:48 ` Pablo Neira Ayuso
2017-10-24 16:42 ` Phil Sutter [this message]
2017-11-09 13:25 ` [nft PATCH] libnftables: Unexport enum nftables_exit_codes Phil Sutter
2017-11-09 19:27 ` Phil Sutter
2017-11-10 11:27 ` [nft PATCH v2] " Phil Sutter
2017-11-13 12:31 ` Pablo Neira Ayuso
2017-11-13 12:38 ` Phil Sutter
2017-11-13 14:08 ` [nft PATCH v3] " Phil Sutter
2017-11-16 13:33 ` Pablo Neira Ayuso
2017-11-16 13:48 ` Phil Sutter
2017-11-13 13:49 ` [nft PATCH v2] " Phil Sutter
2017-11-13 13:53 ` Pablo Neira Ayuso
2017-11-13 14:04 ` Phil Sutter
2017-10-23 15:33 ` [nft PATCH v2 2/4] libnftables: Introduce nft_ctx_flush_cache() Phil Sutter
2017-10-24 15:52 ` Pablo Neira Ayuso
2017-10-24 17:40 ` Phil Sutter
2017-10-25 9:25 ` Pablo Neira Ayuso
2017-10-25 11:40 ` [nft PATCH] libnftables: Get rid of explicit cache flushes Phil Sutter
2017-10-26 18:15 ` Pablo Neira Ayuso
2017-10-23 15:33 ` [nft PATCH v2 3/4] cli: Use nft_run_cmd_from_buffer() Phil Sutter
2017-10-23 15:33 ` [nft PATCH v2 4/4] libnftables: Introduce getters and setters for everything Phil Sutter
2017-10-24 15:20 ` [nft PATCH v2 0/4] libnftables preparations Pablo Neira Ayuso
2017-10-24 16:29 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024164231.GQ32305@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=eric@regit.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).