From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat_snmp_basic: use asn1 decoder library
Date: Mon, 6 Nov 2017 15:44:02 +0100 [thread overview]
Message-ID: <20171106144402.GA10271@salvia> (raw)
In-Reply-To: <20171029123453.2267-1-ap420073@gmail.com>
On Sun, Oct 29, 2017 at 09:34:53PM +0900, Taehee Yoo wrote:
> The basic SNMP ALG parse snmp ASN.1 payload
> however, since 2012 linux kernel provide ASN.1 decoder library.
> If we use ASN.1 decoder in the /lib/asn1_decoder.c, we can remove
> about 1000 line of ASN.1 parsing routine.
>
> To use asn1_decoder.c, we should write mib file(nf_nat_snmp_basic.asn1)
> then /script/asn1_compiler.c makes *-asn1.c and *-asn1.h file
> at the compiletime.(nf_nat_snmp_basic-asn1.c, nf_nat_snmp_basic-asn1.h)
> The nf_nat_snmp_basic.asn1 is made by RFC1155, RFC1157, RFC1902, RFC1905,
> RFC2578, RFC3416. of course that mib file supports only the basic SNMP ALG.
>
> Previous SNMP ALG mangles only first octet of IPv4 address.
> but after this patch, the SNMP ALG mangles whole IPv4 Address.
> And SNMPv3 is not supported.
>
> I tested with snmp commands such ans snmpd, snmpwalk, snmptrap.
OK, something is missing here, I see no definition for
nf_nat_snmp_basic_decoder.
next prev parent reply other threads:[~2017-11-06 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 12:34 [PATCH] netfilter: nf_nat_snmp_basic: use asn1 decoder library Taehee Yoo
2017-11-06 14:44 ` Pablo Neira Ayuso [this message]
2017-11-07 10:47 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106144402.GA10271@salvia \
--to=pablo@netfilter.org \
--cc=ap420073@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).