From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: conntrack: use power efficient workqueue Date: Mon, 6 Nov 2017 15:56:32 +0100 Message-ID: <20171106145632.GA20091@salvia> References: <1509635767-12253-1-git-send-email-vincent.guittot@linaro.org> <20171106143155.GA8738@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Vincent Guittot Return-path: Received: from mail.us.es ([193.147.175.20]:32908 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932276AbdKFO4o (ORCPT ); Mon, 6 Nov 2017 09:56:44 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 0AA741B8401 for ; Mon, 6 Nov 2017 15:56:43 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id F0256DA385 for ; Mon, 6 Nov 2017 15:56:42 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171106143155.GA8738@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Nov 06, 2017 at 03:31:55PM +0100, Pablo Neira Ayuso wrote: > On Thu, 2 Nov 2017 15:16:07 +0100 Vincent Guittot wrote: > > conntrack uses the bounded system_long_wq workqueue for its works that > > don't have to run on the cpu they have been queued. Using bounded > > workqueue prevents the scheduler to make smart decision about the best > > place to schedule the work. > > > > This patch replaces system_long_wq with system_power_efficient_wq. > > the work stays bounded to a cpu by default unless the > > CONFIG_WQ_POWER_EFFICIENT is enable. In the latter case, the work can > > be scheduled on the best cpu from a power or a performance point of > > view. > > Applied, thanks. I'm stepping back. According to what I'm reading system_power_efficient_wq becomes system_wq when disabled, which is not semantically the same as system_long_wq that we have now. My concern is that the conntrack garbage collector may run for quite a bit of time. Did you test this with a large conntrack table full of entries? Thanks.