From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH] libnftables: Flush iface cache after command execution
Date: Thu, 9 Nov 2017 13:24:57 +0100 [thread overview]
Message-ID: <20171109122457.25190-1-phil@nwl.cc> (raw)
In-Reply-To: <20171108234747.GD1788@salvia>
Commit 94a945ffa81b7 ("libnftables: Get rid of explicit cache flushes")
was a bit too optimistic in that it missed the remaining need to flush
interface cache after each command in interactive mode - otherwise,
newly added interfaces won't be recognized.
Although cli.c only calls nft_run_cmd_from_buffer(), flush caches in
nft_run_cmd_from_filename() as well for matters of consistency.
Fixes: 94a945ffa81b7 ("libnftables: Get rid of explicit cache flushes")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/libnftables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libnftables.c b/src/libnftables.c
index 0d04ec21d57d3..dc6a5fdf32640 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -290,6 +290,7 @@ int nft_run_cmd_from_buffer(struct nft_ctx *nft, char *buf, size_t buflen)
erec_print_list(&nft->output, &msgs, nft->debug_mask);
nft_ctx_set_output(nft, fp);
scanner_destroy(scanner);
+ iface_cache_release();
return rc;
}
@@ -322,6 +323,7 @@ err:
erec_print_list(&nft->output, &msgs, nft->debug_mask);
nft_ctx_set_output(nft, fp);
scanner_destroy(scanner);
+ iface_cache_release();
return rc;
}
--
2.13.1
next prev parent reply other threads:[~2017-11-09 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 10:15 nft: I broke interactive mode with iface changes Phil Sutter
2017-11-08 23:47 ` Pablo Neira Ayuso
2017-11-09 12:24 ` Phil Sutter [this message]
2017-11-13 12:36 ` [nft PATCH] libnftables: Flush iface cache after command execution Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109122457.25190-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).