From: Florian Westphal <fw@strlen.de>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v4 12/18] nfnetlink_gueue: exit_net cleanup check added
Date: Sun, 12 Nov 2017 09:52:32 +0100 [thread overview]
Message-ID: <20171112085232.GJ5512@breakpoint.cc> (raw)
In-Reply-To: <c0d49d64-d46b-21e6-02e4-4c445600bd39@virtuozzo.com>
Vasily Averin <vvs@virtuozzo.com> wrote:
> Be sure that instance_table array initialized in net_init hook
> was return to initial state.
> + for (i = 0; i < INSTANCE_BUCKETS; i++)
> + if (WARN_ON_ONCE(!hlist_empty(&q->instance_table[i])))
> + break;
This looks strange, why if/break?
Plain WARN_ON_ONCE should be enough, but thats a nit so:
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-11-12 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9dfa013e-9098-e155-9c47-a73753338288@virtuozzo.com>
2017-11-12 8:39 ` [PATCH v4 00/18] exit_net checks for objects initialized in net_init hook Vasily Averin
2017-11-12 11:32 ` [PATCH v5 0/5] netfilter: " Vasily Averin
2017-11-12 11:44 ` Florian Westphal
2017-11-13 12:55 ` Pablo Neira Ayuso
2017-11-12 11:32 ` [PATCH v5 1/5] clusterip: exit_net cleanup check added Vasily Averin
2017-11-12 11:33 ` [PATCH v5 2/5] nf_tables: " Vasily Averin
2017-11-12 11:33 ` [PATCH v5 3/5] nfnetlink_log: " Vasily Averin
2017-11-12 11:34 ` [PATCH v5 4/5] nfnetlink_gueue: " Vasily Averin
2017-11-12 11:35 ` [PATCH v5 5/5] x_tables: " Vasily Averin
2017-11-12 8:44 ` [PATCH v4 09/18] clusterip: " Vasily Averin
2017-11-12 8:45 ` [PATCH v4 10/18] nf_tables: " Vasily Averin
2017-11-12 8:46 ` [PATCH v4 11/18] nfnetlink_log: " Vasily Averin
2017-11-12 8:53 ` Florian Westphal
2017-11-12 11:28 ` Sergei Shtylyov
2017-11-12 8:47 ` [PATCH v4 12/18] nfnetlink_gueue: " Vasily Averin
2017-11-12 8:52 ` Florian Westphal [this message]
2017-11-12 9:02 ` Vasily Averin
2017-11-12 8:47 ` [PATCH v4 13/18] x_tables: " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112085232.GJ5512@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).