From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH net-next] netfilter: add ifdef around ctnetlink_proto_size
Date: Thu, 16 Nov 2017 10:50:41 +0900 (KST) [thread overview]
Message-ID: <20171116.105041.804470304446588046.davem@davemloft.net> (raw)
In-Reply-To: <20171115172821.8451-1-pablo@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 15 Nov 2017 18:28:21 +0100
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is no longer marked 'inline', so we now get a warning
> when it is unused:
>
> net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size' defined but not used [-Werror=unused-function]
>
> We could mark it inline again, mark it __maybe_unused, or add an #ifdef
> around the definition. I'm picking the third approach here since that
> seems to be what the rest of the file has.
>
> Fixes: 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied.
next prev parent reply other threads:[~2017-11-16 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 17:28 [PATCH net-next] netfilter: add ifdef around ctnetlink_proto_size Pablo Neira Ayuso
2017-11-16 1:50 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-07 14:11 [PATCH] [net-next] " Arnd Bergmann
2017-11-13 12:43 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116.105041.804470304446588046.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).