netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jason Hendry <jhendry@mintel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: conntracd init.d reload is broken on Centos6
Date: Thu, 16 Nov 2017 14:25:28 +0100	[thread overview]
Message-ID: <20171116132528.GA2159@salvia> (raw)
In-Reply-To: <CAPyb0YcPtkruBLSVfxBnU1jrkL_5PgCxLvN56pMgexPHx=RZrQ@mail.gmail.com>

On Thu, Nov 16, 2017 at 10:47:15AM +0000, Jason Hendry wrote:
> Hi,
> 
> Was not sure where to send this so hoping this is the right place.  We
> am running Centos6 with conntrack-tools.  The reload option to the
> conntrackd init.d script does not work due to a syntax error on the
> killproc init function.
[...]
> Index: conntrackd
> ===================================================================
> --- conntrackd   (revision 46829)
> +++ conntrackd   (working copy)
> @@ -85,7 +85,7 @@
>  # XXX: can conntrackd reload?
>  reload() {
>          echo -n $"Reloading $prog configuration: "
> -        killproc -HUP $prog
> +        killproc $prog -HUP
>          retval=$?
>          echo
>          return $retval
> 
> 
> If you prefer this be submitted somewhere else or in a different
> format I am happy to do so.

I think you have to send this to the CentOS people, I don't see such
script on our git tree.

Thanks.

  reply	other threads:[~2017-11-16 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 10:47 conntracd init.d reload is broken on Centos6 Jason Hendry
2017-11-16 13:25 ` Pablo Neira Ayuso [this message]
2017-11-17 22:55   ` Jason Hendry
2017-11-18 12:47     ` Arturo Borrero Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116132528.GA2159@salvia \
    --to=pablo@netfilter.org \
    --cc=jhendry@mintel.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).