From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] libnftables: Split code into frontend and library
Date: Thu, 16 Nov 2017 14:34:48 +0100 [thread overview]
Message-ID: <20171116133448.GC2455@salvia> (raw)
In-Reply-To: <20171114201710.16419-1-phil@nwl.cc>
On Tue, Nov 14, 2017 at 09:17:10PM +0100, Phil Sutter wrote:
> This finally creates the libnftables shared object.
>
> For some reason, this causes two compiler warnings to appear:
>
> | parser_bison.y: In function 'nft_parse':
> | parser_bison.y:131:3: warning: implicit declaration of function 'nft_set_debug' [-Wimplicit-function-declaration]
> | nft_set_debug(1, scanner);
> | ^~~~~~~~~~~~~
> | parser_bison.c:64:25: warning: implicit declaration of function 'nft_lex' [-Wimplicit-function-declaration]
> | #define yylex nft_lex
> | ^
> | parser_bison.c:4745:16: note: in expansion of macro 'yylex'
> | yychar = yylex (&yylval, &yylloc, scanner);
>
> So this patch contains a workaround, namely declaring both functions
> in src/parser_bison.y. During linking the objects are found, so this is
> rather a matter of cosmetics.
Also applied, thanks Phil.
Upfront warning: I will not consider this API stable until we make the
0.9 release, so we have a bit more time to make API changes.
next prev parent reply other threads:[~2017-11-16 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 20:17 [nft PATCH] libnftables: Split code into frontend and library Phil Sutter
2017-11-16 13:34 ` Pablo Neira Ayuso [this message]
2017-11-16 13:56 ` Pablo Neira Ayuso
2017-11-16 14:11 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116133448.GC2455@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).