Re: [nft PATCH] libnftables: Split code into frontend and library

[Phil Sutter <phil@nwl.cc>]

On Thu, Nov 16, 2017 at 02:56:30PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Nov 16, 2017 at 02:34:48PM +0100, Pablo Neira Ayuso wrote:
> > On Tue, Nov 14, 2017 at 09:17:10PM +0100, Phil Sutter wrote:
> > > This finally creates the libnftables shared object.
> > > 
> > > For some reason, this causes two compiler warnings to appear:
> > > 
> > > | parser_bison.y: In function 'nft_parse':
> > > | parser_bison.y:131:3: warning: implicit declaration of function 'nft_set_debug' [-Wimplicit-function-declaration]
> > > |    nft_set_debug(1, scanner);
> > > |    ^~~~~~~~~~~~~
> > > | parser_bison.c:64:25: warning: implicit declaration of function 'nft_lex' [-Wimplicit-function-declaration]
> > > |  #define yylex           nft_lex
> > > |                          ^
> > > | parser_bison.c:4745:16: note: in expansion of macro 'yylex'
> > > |        yychar = yylex (&yylval, &yylloc, scanner);
> > > 
> > > So this patch contains a workaround, namely declaring both functions
> > > in src/parser_bison.y. During linking the objects are found, so this is
> > > rather a matter of cosmetics.
> > 
> > Also applied, thanks Phil.
> 
> This message is popping up here:
> 
>   CCLD     libnftables.la
> ar: `u' modifier ignored since `D' is the default (see `U')

Looks like an automake bug on your system? (Googling turned this up:
https://bugzilla.redhat.com/show_bug.cgi?id=1155273). I don't see the
warning on my machine at least.

Cheers, Phil
>