From: Harsha Sharma <harshasharmaiitr@gmail.com>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org,
Harsha Sharma <harshasharmaiitr@gmail.com>
Subject: [PATCH] evaluate: print error for null string befort assert statement
Date: Fri, 24 Nov 2017 00:25:14 +0530 [thread overview]
Message-ID: <20171123185514.16711-1-harshasharmaiitr@gmail.com> (raw)
Print error "Null string is not allowed" before assert statement.
For e.g.
nft add rule filter input meta iifname '""'
Error: Null String is not allowed
add rule filter input meta iifname ""
Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
---
src/evaluate.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/evaluate.c b/src/evaluate.c
index fd61e75..ad044a4 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -235,6 +235,10 @@ static int expr_evaluate_string(struct eval_ctx *ctx, struct expr **exprp)
memset(data + len, 0, data_len - len);
mpz_export_data(data, expr->value, BYTEORDER_HOST_ENDIAN, len);
+ if (strlen(data) == 0) {
+ return expr_error(ctx->msgs, expr,
+ "Null String is not allowed");
+ }
assert(strlen(data) > 0);
datalen = strlen(data) - 1;
if (data[datalen] != '*') {
--
2.11.0
next reply other threads:[~2017-11-23 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 18:55 Harsha Sharma [this message]
2017-11-23 21:25 ` [PATCH] evaluate: print error for null string befort assert statement Florian Westphal
2017-11-27 22:39 ` Pablo Neira Ayuso
2017-11-27 22:48 ` Florian Westphal
2017-11-27 22:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123185514.16711-1-harshasharmaiitr@gmail.com \
--to=harshasharmaiitr@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).