From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH nf-next] netfilter: meta: secpath support Date: Fri, 1 Dec 2017 14:07:47 +0100 Message-ID: <20171201130747.GD27820@breakpoint.cc> References: <20171201124021.20973-1-fw@strlen.de> <20171201124021.20973-2-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , Netfilter Development Mailing list To: Arturo Borrero Gonzalez Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:40948 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbdLANJB (ORCPT ); Fri, 1 Dec 2017 08:09:01 -0500 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Arturo Borrero Gonzalez wrote: > > + if (priv->key != NFT_META_SECPATH) > > + return 0; > > + > > Would it worth adding here something like this? > > #ifnfdef CONFIG_XFRM > return -EOPNOTSUPP; > #endif > > I mean, if CONFIG_XFRM is not defined, then _get_eval() is doing nothing, right? Right, I'll add it.