From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Debabrata Banerjee <dbanerje@akamai.com>,
"David S . Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] Fix handling of verdicts after NF_QUEUE
Date: Thu, 14 Dec 2017 18:39:34 +0100 [thread overview]
Message-ID: <20171214173934.GA10610@kroah.com> (raw)
In-Reply-To: <20171214123008.jae4xa4nnpqdeoli@salvia>
On Thu, Dec 14, 2017 at 01:30:08PM +0100, Pablo Neira Ayuso wrote:
> Hi Greg,
>
> I'd appreciate if you can take this patch into 4.9-stable. There is no
> similar patch in tree, so this is not a backport.
>
> On Wed, Dec 13, 2017 at 03:33:37PM -0500, Debabrata Banerjee wrote:
> > A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value
> > and a potential kernel panic via double free of skb's
> >
> > This was broken by commit 7034b566a4e7 ("netfilter: fix nf_queue handling")
> > and subsequently fixed in v4.10 by commit c63cbc460419 ("netfilter:
> > use switch() to handle verdict cases from nf_hook_slow()"). However that
> > commit cannot be cleanly cherry-picked to v4.9
> >
> > Signed-off-by: Debabrata Banerjee <dbanerje@akamai.com>
>
> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Thanks a lot!
Now applied, thanks.
greg k-h
next prev parent reply other threads:[~2017-12-14 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 20:33 [PATCH] Fix handling of verdicts after NF_QUEUE Debabrata Banerjee
2017-12-14 12:30 ` Pablo Neira Ayuso
2017-12-14 17:39 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 23:30 Debabrata Banerjee
2017-12-12 0:23 ` Pablo Neira Ayuso
2017-12-12 0:36 ` Banerjee, Debabrata
2017-12-12 22:42 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214173934.GA10610@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dbanerje@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).