From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [libnftnl PATCH 4/6] src/ruleset: Avoid reading garbage in nftnl_ruleset_cb()
Date: Thu, 14 Dec 2017 20:40:23 +0100 [thread overview]
Message-ID: <20171214194025.21334-5-phil@nwl.cc> (raw)
In-Reply-To: <20171214194025.21334-1-phil@nwl.cc>
If nftnl_ruleset_json_parse() is called with arg == NULL, ctx.data is
left uninitialized and will later be used in nftnl_ruleset_cb(). Avoid
this by using a C99-style initializer for 'ctx' which sets all omitted
fields to zero.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/ruleset.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/ruleset.c b/src/ruleset.c
index 3de9b87283292..cf86ca68a51f3 100644
--- a/src/ruleset.c
+++ b/src/ruleset.c
@@ -519,11 +519,11 @@ static int nftnl_ruleset_json_parse(const void *json,
json_error_t error;
int i, len;
const char *key;
- struct nftnl_parse_ctx ctx;
-
- ctx.cb = cb;
- ctx.format = type;
- ctx.flags = 0;
+ struct nftnl_parse_ctx ctx = {
+ .cb = cb,
+ .format = type,
+ .flags = 0,
+ };
ctx.set_list = nftnl_set_list_alloc();
if (ctx.set_list == NULL)
--
2.13.1
next prev parent reply other threads:[~2017-12-14 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 19:40 [libnftnl PATCH 0/6] Another round of Covscan indicated fixes Phil Sutter
2017-12-14 19:40 ` [libnftnl PATCH 1/6] nftnl_data_reg_snprintf: Add a missing break Phil Sutter
2017-12-15 15:17 ` Pablo Neira Ayuso
2017-12-14 19:40 ` [libnftnl PATCH 2/6] src/gen: Remove a pointless call to mnl_nlmsg_get_payload() Phil Sutter
2017-12-15 15:17 ` Pablo Neira Ayuso
2017-12-14 19:40 ` [libnftnl PATCH 3/6] src/object: Avoid returning garbage in nftnl_obj_do_parse() Phil Sutter
2017-12-15 15:18 ` Pablo Neira Ayuso
2017-12-14 19:40 ` Phil Sutter [this message]
2017-12-15 15:18 ` [libnftnl PATCH 4/6] src/ruleset: Avoid reading garbage in nftnl_ruleset_cb() Pablo Neira Ayuso
2017-12-14 19:40 ` [libnftnl PATCH 5/6] src/set_elem: Don't return garbage in nftnl_set_elems_parse() Phil Sutter
2017-12-15 15:19 ` Pablo Neira Ayuso
2017-12-14 19:40 ` [libnftnl PATCH 6/6] src/trace: Check return value of mnl_attr_parse_nested() Phil Sutter
2017-12-15 15:20 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214194025.21334-5-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).