From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] netfilter: connlimit: fix boolreturn.cocci warnings Date: Wed, 20 Dec 2017 01:46:41 +0800 Message-ID: <20171219174641.GA30912@lkp-wsm-ep1> References: <201712200137.1Bakdeow%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Pablo Neira Ayuso To: Florian Westphal Return-path: Received: from mga06.intel.com ([134.134.136.31]:60586 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdLSRrn (ORCPT ); Tue, 19 Dec 2017 12:47:43 -0500 Content-Disposition: inline In-Reply-To: <201712200137.1Bakdeow%fengguang.wu@intel.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Fengguang Wu net/netfilter/nf_conncount.c:74:9-10: WARNING: return of 0/1 in function 'already_closed' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 61b781a5a0bb ("netfilter: connlimit: split xt_connlimit into front and backend") CC: Florian Westphal Signed-off-by: Fengguang Wu --- nf_conncount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/netfilter/nf_conncount.c +++ b/net/netfilter/nf_conncount.c @@ -71,7 +71,7 @@ static inline bool already_closed(const return conn->proto.tcp.state == TCP_CONNTRACK_TIME_WAIT || conn->proto.tcp.state == TCP_CONNTRACK_CLOSE; else - return 0; + return false; } static int key_diff(const u32 *a, const u32 *b, unsigned int klen)