From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] netfilter: connlimit: fix ptr_ret.cocci warnings Date: Wed, 20 Dec 2017 01:46:41 +0800 Message-ID: <20171219174641.GA31011@lkp-wsm-ep1> References: <201712200137.1Bakdeow%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Pablo Neira Ayuso To: Florian Westphal Return-path: Received: from mga01.intel.com ([192.55.52.88]:7635 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbdLSRrq (ORCPT ); Tue, 19 Dec 2017 12:47:46 -0500 Content-Disposition: inline In-Reply-To: <201712200137.1Bakdeow%fengguang.wu@intel.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Fengguang Wu net/netfilter/xt_connlimit.c:96:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 61b781a5a0bb ("netfilter: connlimit: split xt_connlimit into front and backend") CC: Florian Westphal Signed-off-by: Fengguang Wu --- xt_connlimit.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/net/netfilter/xt_connlimit.c +++ b/net/netfilter/xt_connlimit.c @@ -93,10 +93,7 @@ static int connlimit_mt_check(const stru /* init private data */ info->data = nf_conncount_init(par->net, par->family, keylen); - if (IS_ERR(info->data)) - return PTR_ERR(info->data); - - return 0; + return PTR_ERR_OR_ZERO(info->data); } static void connlimit_mt_destroy(const struct xt_mtdtor_param *par)